Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: file-resolver protocol error handling #427

Merged
merged 1 commit into from
Mar 31, 2022
Merged

feat: file-resolver protocol error handling #427

merged 1 commit into from
Mar 31, 2022

Conversation

DeMoorJasper
Copy link
Member

@DeMoorJasper DeMoorJasper commented Mar 31, 2022 •
edited
Loading

What kind of change does this pull request introduce?

What is the current behavior?

Errors result in messages not receiving a response

New behavior?

Errors are returned back to the bundler

Future work

Rebuild the protocol from the ground up, there's a few things that might cause issues.

@DeMoorJasper DeMoorJasper requested a review from danilowoz March 31, 2022 09:03
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0ea26fa:

Sandbox Source
Sandpack Blog Example 1 Configuration

@github-actions
Copy link

github-actions bot commented Mar 31, 2022 •
edited
Loading

Size changes

sandpack-react

Total base (gzip) Total current (gzip) +/-
161 kb 161 kb ✅ 0 byte
Details
Dependency name / file Base Current +/-
0 522 kb 522 kb ✅ 0 byte
main 456 kb 456 kb ✅ 0 byte
index.css 27 kb 27 kb ✅ 0 byte
@codesandbox/sandpack-react 70 kb 70 kb ✅ 0 byte
@code-hike/classer 1 kb 1 kb ✅ 0 byte
@codesandbox/sandpack-client 13 kb 13 kb ✅ 0 byte
@codemirror/state 35 kb 35 kb ✅ 0 byte
@codemirror/view 167 kb 167 kb ✅ 0 byte
@codemirror/closebrackets 6 kb 6 kb ✅ 0 byte
@codemirror/matchbrackets 4 kb 4 kb ✅ 0 byte
@codemirror/commands 24 kb 24 kb ✅ 0 byte
@codemirror/comment 5 kb 5 kb ✅ 0 byte
@codemirror/gutter 10 kb 10 kb ✅ 0 byte
@codemirror/highlight 12 kb 12 kb ✅ 0 byte
@codemirror/history 9 kb 9 kb ✅ 0 byte
@react-hook/intersection-observer 2 kb 2 kb ✅ 0 byte
@codemirror/lang-css 11 kb 11 kb ✅ 0 byte
@codemirror/lang-javascript 6 kb 6 kb ✅ 0 byte
@codemirror/lang-html 15 kb 15 kb ✅ 0 byte
@codemirror/text 13 kb 13 kb ✅ 0 byte
style-mod 3 kb 3 kb ✅ 0 byte
@codemirror/rangeset 16 kb 16 kb ✅ 0 byte
w3c-keyname 2 kb 2 kb ✅ 0 byte
@lezer/common 34 kb 34 kb ✅ 0 byte
@codemirror/language 19 kb 19 kb ✅ 0 byte
@react-hook/passive-layout-effect 191 bytes 191 bytes ✅ 0 byte
@lezer/css 9 kb 9 kb ✅ 0 byte
@lezer/html 12 kb 12 kb ✅ 0 byte
@lezer/javascript 54 kb 54 kb ✅ 0 byte
@codemirror/autocomplete 34 kb 34 kb ✅ 0 byte
@lezer/lr 31 kb 31 kb ✅ 0 byte
@codemirror/tooltip 14 kb 14 kb ✅ 0 byte
lodash.isequal 18 kb 18 kb ✅ 0 byte
codesandbox-import-utils 367 bytes 367 bytes ✅ 0 byte
react-devtools-inline 823 kb 823 kb ✅ 0 byte
webpack 487 bytes 487 bytes ✅ 0 byte
intersection-observer 13 kb 13 kb ✅ 0 byte
lz-string 9 kb 9 kb ✅ 0 byte
react-is 2 kb 2 kb ✅ 0 byte

sandpack-client

Total base (gzip) Total current (gzip) +/-
7 kb 7 kb ⚠️ +53 bytes (+0.72%)
Details
Dependency name / file Base Current +/-
main 20 kb 21 kb ⚠️ +110 bytes (+0.53%)
@codesandbox/sandpack-client 11 kb 11 kb ⚠️ +145 bytes (+1.30%)
codesandbox-import-utils 3 kb 3 kb ✅ 0 byte
lodash.isequal 18 kb 18 kb ✅ 0 byte
webpack 487 bytes 487 bytes ✅ 0 byte

@DeMoorJasper DeMoorJasper merged commit c3b3cca into main Mar 31, 2022
@DeMoorJasper DeMoorJasper deleted the feat/file-resolver-tweaks branch March 31, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilowoz danilowoz Awaiting requested review from danilowoz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DeMoorJasper